Morrowind talk:Conjuration Spells

Rearranged tables for mobile

Hi, I noticed the tables on this page caused horizontal scroll on some mobile screens. So I rearranged the tables to fit: before-monobook, after-monobook, before-vector, after-vector, before-minerva, after-minerva. Before I make similar changes to the other five Morrowind spell pages, does anyone notice problems, or have suggestions? 108.184.13.99 10:24, 21 April 2018 (UTC)

Don't take this the wrong way, but the mobile versions do not take priority over the desktop versions. Wiki's as a whole aren't particularly adapted to mobile displays. Other than using mediawiki formatting over html, and some extraneous coding the only thing I would have an issue with is a forced maximum width. It doesn't really make much difference for display as the columns in each table are of differing widths, and the columns don't line up between the tables, and all that white-space in the smaller tables is undesirable. Silence is Golden^{Break the Silence} 19:29, 21 April 2018 (UTC)

Yeah, I wasn't sure what to make of "width=100%" — whether the author wanted to keep the tables uniform in width, or as wide as was possible on 2007 monitors, or what. I like the way you did it better, with no width constraints.

I think h2's are the correct heading level for the current page structure, == instead of ===, so Google etc. don't think the whole page is part of the table of contents (nearest ancestor h2). Or maybe keep an h3 on each table, but group the tables under h2's? 108.184.13.99 01:21, 22 April 2018 (UTC)

With the tables twice as wide they were almost the whole page, and with smaller screen resolutions they probably already were, so it would have made sense to fill it up. Mediawiki formatting is a necessity, not an option. If it is the actual toc you are worried about it could be moved to the right hand side of the page {{TOCright}}. Also, pages usually have at least one more lines about its contents, and that could be followed by a simple higher-level header entitled Spells, though this would interfere with the toc display with a rather unnecessary sup-section. Silence is Golden^{Break the Silence} 20:38, 22 April 2018 (UTC)

Duplicate id's

Just noticed this page has duplicate id's every time a spell name is the same as a spell effect heading. That makes links to those id's unpredictable - Morrowind:Conjuration Spells#Bound Boots might go to the heading, or might go to the spell, depending on what your browser feels like doing. I'll try changing duplicate spell id's to something unique, like id="Bound_Boots-spell", and see how that works. 108.184.13.99 09:28, 22 April 2018 (UTC)

The {{LE}} template works for this, it makes whichever one you use it on the target for any links. Silence is Golden^{Break the Silence} 12:25, 22 April 2018 (UTC)

So here's one way to fix it: I changed the id's on the invisible anchors to add "_spell" to any duplicates (diff), and updated the incoming redirects (example diff). There are other ways to fix it, such as changing the text of the headings ("===Turn Undead spells===" perhaps). 108.184.13.99 19:02, 22 April 2018 (UTC)

I didn't realise there were already LE's on the page. The header formatting makes the header a linkable entry too, which is causing the problem, though I thought that the template was supposed to override that. I also thought the point of having headers was to link to the header, as linking to the spell on longer ones actually cuts off the first few sellers, such as with Summon Flame Atronach, which cuts off Malvin and Medila when it links to the spell. If it is really desirable to link to the spell, then it's kind of redundant on a "spells" page to change the headers to use Spells. It would need to be on all headers for consistency, and it would have to be capitalised. Also, put the name inside the template, instead of leaving the first parameter blank. Silence is Golden^{Break the Silence} 20:29, 22 April 2018 (UTC)

I'm not keen on changing the heading text either. Few other possibilities: 1) I could align the table cells to their tops, which would prevent NPCs from getting cut off. The mobile skin already aligns cells like that, and it's possibly easier to read text that flows more rightward and less upward. 2) I could adjust the anchors to align with the top of the table row, even if the cells are middle aligned. This would not change the tables visibly, except that the NPCs no longer get cut off. 3) I could scrap the id's on individual spells, and have, for example, Morrowind:Spells/Blessed Touch, Morrowind:Spells/Holy Word, Morrowind:Spells/Turn Undead etc. all point to the same spot, the "Turn Undead" heading above the table. The heading may be far from the desired spell, though, if there are a lot of spells in a table, like Morrowind:Restoration Spells#Fortify Attribute. 108.184.13.99 21:58, 22 April 2018 (UTC)

I edited the page to test option 1 — vertically aligning all cells to the top. It fixes the NPC cutoff problem, but I'm on the fence about how it looks visually. If it doesn't look good, I won't mind reverting it and trying option 2 or 3 instead. 108.184.13.99 20:26, 23 April 2018 (UTC)

We use vtop in a lot of places, and I think it looks fine in these tables myself, but I'm not particularly for or against it. Moving the id to the table row is certainly another option, though it might throw people off if they're used to using LE, which is span-based. I was in favour of just linking to the header, but your Fortify Attribute example makes a good case for not doing that. I supposed we could link to the header only for shorter sections and directly to the table row for longer ones, but I dislike the inconsistency of that. I'm not sure what else to suggest on that front, though. – Robin Hood  ^(talk) 08:19, 24 April 2018 (UTC)